Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs on issuing jsonld credentials #1136

Merged

Conversation

TimoGlastra
Copy link
Contributor

Adds documentation on issuing JSON-LD credentials. Present Proof is todo and dependant on PR #1125.

Signed-off-by: Timo Glastra <timo@animo.id>
@codecov-commenter
Copy link

Codecov Report

Merging #1136 (b6d7a28) into main (7541002) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1136   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         430      430           
  Lines       24195    24195           
=======================================
  Hits        23881    23881           
  Misses        314      314           

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FYI - @ianco - perhaps you can extend this as you do the demo changes.

@swcurran swcurran merged commit 1678458 into openwallet-foundation:main May 3, 2021
@ianco
Copy link
Contributor

ianco commented May 3, 2021

Looks good. FYI - @ianco - perhaps you can extend this as you do the demo changes.

Yep will do just looking now

@Ennovate-com
Copy link
Contributor

Present Proof is todo and dependant[sic] on PR #1125.

Present Proof (JSON-LD Credentials) mentioned in the OP is still flagged TODO. PRs #1125 and this #1136 closed long ago. Maybe a new issue should be created for tracking that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants