feat: send webhooks for forward messages #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests are my fault, fix in #1151 |
TimoGlastra
force-pushed
the
feature/foward-webhook-events
branch
from
d64905c
to
d521075
Compare
|
Updated |
andrewwhitehead
previously approved these changes
May 5, 2021
|
The branch needs updating/rebasing Oops, and now there's a conflict, sorry :) |
Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra
force-pushed
the
feature/foward-webhook-events
branch
from
d521075
to
edfd5b5
Compare
andrewwhitehead
approved these changes
May 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to ACA-Py to send webhook events on received forward messages (
--monitor-forward, taken frommonitor-ping).I extended the
OutboundSendStatuswork from Daniel and added a few more status options. These are then included in the webhook event, so the controller can react to the event.If
--monitor-forwardis not enabled, the event is still dispatched in the event bus (just not as webhook), so other parts of the codebase/plugins can hook into this if they want to manage it in ACA-Py instead of the controller