Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate schema in send_schema by always fetching first #126

Merged

Conversation

andrewwhitehead
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #126 into master will decrease coverage by 0.1%.
The diff coverage is 54.83%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   73.06%   72.96%   -0.11%     
==========================================
  Files         186      186              
  Lines        7983     8000      +17     
==========================================
+ Hits         5833     5837       +4     
- Misses       2150     2163      +13

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and ran the demo. All looks good. The method of being notified of the error is not my favourite (scan error message), but that's someone else's code...

@swcurran swcurran merged commit f6dba8e into openwallet-foundation:master Aug 8, 2019
@andrewwhitehead andrewwhitehead deleted the handle-dupe-schema branch February 29, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants