Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify instructions in Acme Controller Workshop #1482

Closed
wants to merge 2 commits into from

Conversation

eliasschoof
Copy link
Contributor

Closes #1477.

The instructions at this place were unclear, see openwallet-foundation#1477. This is a proposed fix that makes it clear where the code snippet should be inserted.

Signed-off-by: Elias Strehle <elias@circulartree.com>
Reflect changes made in Acme Controller Workshop instructions

Signed-off-by: Elias Strehle <elias@circulartree.com>
@eliasschoof
Copy link
Contributor Author

Sorry, I seem unable to make the DCO test pass. Would appreciate your help.

@ianco
Copy link
Contributor

ianco commented Nov 9, 2021

Sorry, I seem unable to make the DCO test pass. Would appreciate your help.

To DCO signoff your commits you use the git commit -s or git commit --signoff option, it's tough to fix if you do it wrong. You can try the instructions linked on the DCO details link, or sometimes I just create a new branch and start over.

@eliasschoof
Copy link
Contributor Author

Sorry, I seem unable to make the DCO test pass. Would appreciate your help.

To DCO signoff your commits you use the git commit -s or git commit --signoff option, it's tough to fix if you do it wrong. You can try the instructions linked on the DCO details link, or sometimes I just create a new branch and start over.

Thanks! I made a new PR: #1484.

@eliasschoof eliasschoof deleted the patch-3 branch November 10, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acme Controller Workshop: Unclear instructions for issuing work credential
2 participants