Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when getting credentials on askar-profile #1510

Merged
merged 4 commits into from
Nov 24, 2021

Conversation

baegjae
Copy link
Contributor

@baegjae baegjae commented Nov 23, 2021

This PR fixes bug when getting credentials under askar-profile environment.

Environment

askar-profile

Problem

After holder received credential from issuer, holder get empty results when getting credentials.

Fix

Add profile parameter with wallet.askar_profile when scanning credentials

Thanks!

Signed-off-by: Ethan Sung baegjae@gmail.com

Signed-off-by: Ethan Sung <baegjae@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1510 (65acac8) into main (9224d3f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1510   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files         509      509           
  Lines       30985    30985           
=======================================
  Hits        29683    29683           
  Misses       1302     1302           

@ianco
Copy link
Contributor

ianco commented Nov 23, 2021

Uh oh black formatter check fails: ... would reformat aries_cloudagent/indy/credx/holder.py

Signed-off-by: Ethan Sung <baegjae@gmail.com>
@baegjae
Copy link
Contributor Author

baegjae commented Nov 24, 2021

Uh oh black formatter check fails: ... would reformat aries_cloudagent/indy/credx/holder.py

@ianco
Oh, I missed it. Now all checks have passed. :)

@ianco ianco merged commit 2960c51 into openwallet-foundation:main Nov 24, 2021
@baegjae baegjae deleted the fix-get-credentials branch November 25, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants