Display QR code when generating/displaying invites on startup #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
dbluhm
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Tested and working 🙂 I considered suggesting adding a flag for whether the QR code was printed or not but I think the instances where the --invite flags are used are generally limited to debugging and testing or else are not going to be negatively impacted by a QR code being printed. So not immediately springing for yet another flag seems favorable.
Yes I had the same thought. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo ian@anon-solutions.ca