DID updates for endorser #1601
Merged
DID updates for endorser #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Codecov Report
@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
- Coverage 95.74% 95.64% -0.11%
==========================================
Files 528 528
Lines 32515 32587 +72
==========================================
+ Hits 31133 31169 +36
- Misses 1382 1418 +36 |
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
| @@ -181,6 +224,7 @@ async def register_ledger_nym(request: web.BaseRequest): | |||
| request: aiohttp request object | |||
| """ | |||
| context: AdminRequestContext = request["context"] | |||
| outbound_handler = request["outbound_message_router"] | |||
| async with context.profile.session() as session: | |||
| ledger = session.inject_or(BaseLedger) | |||
There was a problem hiding this comment.
Hm, it's not updated by this PR, but BaseLedger should be injected via the profile not the session. Generally anything injected by the session shouldn't be touched after the async with block as it might refer to a closed session. This is also true for the IndyLedgerRequestExecutor instances which seem to be set up by the conductor.
There was a problem hiding this comment.
OK thanks for the tip!
andrewwhitehead
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo ian@anon-solutions.ca
Adds endorser support to the ledger register_nym function, allowing Authors to self-register a public DID.