Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for v7.3.0 - Issue#1597 #1610

Closed
wants to merge 26 commits into from

Conversation

shaangill025
Copy link
Contributor

Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
@shaangill025
Copy link
Contributor Author

Regarding (3a), I believe it is working as intended:
Started Agent Alice
PORTS="5002 8002" ./scripts/run_docker start --admin 0.0.0.0 5002 --inbound-transport http 0.0.0.0 8002 --outbound-transport http -e http://host.docker.internal:8002 --admin-insecure-mode --public-invites --auto-ping-connection --auto-accept-invites --auto-accept-requests --auto-respond-credential-offer --auto-verify-presentation --genesis-url http://host.docker.internal:9000/genesis --seed 00000000000000000000000000000008 --auto-provision --recreate-wallet --wallet-type indy --wallet-name issuer --wallet-key mykey

Started Agent Bob
PORTS="5003 8003" ./scripts/run_docker start --admin 0.0.0.0 5003 --inbound-transport http 0.0.0.0 8003 --outbound-transport http -e http://host.docker.internal:8003 --admin-insecure-mode --public-invites --auto-ping-connection --auto-accept-invites --auto-accept-requests --auto-respond-credential-proposal --auto-respond-credential-request --auto-respond-presentation-proposal --auto-verify-presentation --genesis-url http://host.docker.internal:9000/genesis --seed 00000000000000000000000000000007 --auto-provision --recreate-wallet --wallet-type indy --wallet-name issuer --wallet-key mykey

From Bob, /issue-credential-2.0/send-request with the following credential

{
    "connection_id": "....",
    "filter": {
        "ld_proof": {
            "credential": {
                "@context": [
                    "https://www.w3.org/2018/credentials/v1",
                    "https://w3id.org/citizenship/v1",
                    "https://w3id.org/security/bbs/v1"
                ],
                "type": [
                    "VerifiableCredential",
                    "PermanentResidentCard"
                ],
                "issuer": "....",
                "identifier": "83627465",
                "name": "Permanent Resident Card",
                "description": "Government of Example Permanent Resident Card 1.",
                "issuanceDate": "2010-01-01T19:53:24Z",
                "expirationDate": "2029-12-03T12:19:52Z",
                "credentialSubject": {
                    "id": "....",
                    "type": [
                        "PermanentResident",
                        "Person"
                    ],
                    "givenName": "JOHN",
                    "familyName": "SMITH",
                    "gender": "Male",
                    "image": "data:image/png;base64,iVBORw0KGgokJggg==",
                    "residentSince": "2015-01-01",
                    "lprCategory": "C09",
                    "lprNumber": "999-999-999",
                    "commuterClassification": "C1",
                    "birthCountry": "Bahamas",
                    "birthDate": "1958-07-17"
                }
            },
            "options": {
                "proofType": "Ed25519Signature2018"
            }
        }
    },
    "holder_did": "...."
}

Alice receives the request and does not issue automatically as intended

Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
@shaangill025
Copy link
Contributor Author

#1667 fixes 3b.

@shaangill025
Copy link
Contributor Author

Regarding 2. I am not able to replicate the problem and the cred_rev_id [from IssuerCredRevRecord] is correct in the thread_id for both v1 and v2.

@shaangill025 shaangill025 marked this pull request as ready for review March 16, 2022 18:07
@TimoGlastra TimoGlastra self-requested a review April 5, 2022 15:49
aries_cloudagent/tails/indy_tails_server.py Outdated Show resolved Hide resolved
aries_cloudagent/tails/indy_tails_server.py Outdated Show resolved Hide resolved
requirements.bbs.txt Show resolved Hide resolved
ianco and others added 6 commits April 5, 2022 09:47
Co-authored-by: Timo Glastra <timo@animo.id>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple issues in the 0.7.3 release
3 participants