Add cred_def_id to metadata when using an Endorser #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a transaction is returned during a credential definition, the `cred_def_id` is never returned back to the caller (neither in the response or in the webhooks), however, the schema ID is returned when a cred_def or a schema transaction is created. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
TheTechmage
force-pushed
the
fix/missing-creddef-id-in-transact
branch
from
fb5aff4
to
d4f7174
Compare
|
That was just a rebase |
ianco
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing a new credential definition to the ledger (with the Author/Endorser workflow), the
cred_def_idis nowhere to be found in the transaction response or the webhooks. I have moved the metadata definition lines forcred_def_idandissuer_idto the actual definition point for the metadata and have removed the redundant lines that were in an if block.