Revert change to send_credential_ack return value #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 528 528
Lines 32734 32734
=======================================
Hits 31264 31264
Misses 1470 1470 |
|
FYI -- this fixes the AATH tests. Does reverting mean we don't get the benefits of why the changes were made in the first place (of which I'm not sure...). What's the story of this one? :) |
|
@swcurran No the benefits are still there, I had just changed a method signature so it wasn't returning a copy of the exchange record anymore but that turned out to introduce an issue (this PR also adds a test for the new exchange record state). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1619