-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: DIF proof proposal when creating bound presentation request [Issue#1687] #1690
Fix: DIF proof proposal when creating bound presentation request [Issue#1687] #1690
Conversation
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
@andrewwhitehead -- please review and (hopefully) approve the PR. @shaangill025 do we need a reminder about when to change (or at least check) the locked down Ursa dependency? Maybe I put something in my calendar for (when?) to check this? |
Timo just mentioned in #1704 that |
Signed-off-by: Shaanjot Gill shaangill025@users.noreply.github.com
/present-proof-v2.0/send-proposal
is working but the problem was that withauto_respond_presentation_proposal
flag on it would create an invalid bound request from the proposal [input_descriptors
was not enclosed inpresentation_definition
]. I am surprised that I didn't catch this earlier.propose-presentation
message only expectsinput_descriptors
and nooptions
[forchallenge
and/ordomain
]. With auto flag, there will be no opportunity to add a domain to the request, so I have updated the schema to allowoptions
in thepropose-presentation
message.challenge
is always required for verifying presentation, ifoptions
is not specified then it is randomly assigned.