Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: DIF proof proposal when creating bound presentation request [Issue#1687] #1690

Merged
merged 7 commits into from
Mar 30, 2022

Conversation

shaangill025
Copy link
Contributor

@shaangill025 shaangill025 commented Mar 25, 2022

Signed-off-by: Shaanjot Gill shaangill025@users.noreply.github.com

  • resolve present-proof v2 puts records to the storage it can't read back any more #1687
  • So the validation for /present-proof-v2.0/send-proposal is working but the problem was that with auto_respond_presentation_proposal flag on it would create an invalid bound request from the proposal [input_descriptors was not enclosed in presentation_definition]. I am surprised that I didn't catch this earlier.
  • @swcurran According to the RFC, the propose-presentation message only expects input_descriptors and no options [for challenge and/or domain]. With auto flag, there will be no opportunity to add a domain to the request, so I have updated the schema to allow options in the propose-presentation message. challenge is always required for verifying presentation, if options is not specified then it is randomly assigned.

Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
@swcurran
Copy link
Contributor

@andrewwhitehead -- please review and (hopefully) approve the PR.

@shaangill025 do we need a reminder about when to change (or at least check) the locked down Ursa dependency? Maybe I put something in my calendar for (when?) to check this?

@shaangill025
Copy link
Contributor Author

shaangill025 commented Mar 30, 2022

@shaangill025 do we need a reminder about when to change (or at least check) the locked down Ursa dependency? Maybe I put something in my calendar for (when?) to check this?

Timo just mentioned in #1704 that 1.0.2 was released by mistake. I think we can leave it fixed to 1.0.1 until 1.0.3 release or if we hear otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

present-proof v2 puts records to the storage it can't read back any more
3 participants