Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add anoncreds migration guide #2881

Merged
merged 3 commits into from
May 22, 2024
Merged

Add anoncreds migration guide #2881

merged 3 commits into from
May 22, 2024

Conversation

jamshale
Copy link
Contributor

Adds a migration guide controllers to upgrade to anoncreds.

@jamshale jamshale marked this pull request as ready for review April 11, 2024 17:56
@jamshale jamshale linked an issue Apr 11, 2024 that may be closed by this pull request
Add .md document for controller upgrade to anoncreds #2875
Closed
ianco
ianco previously requested changes Apr 17, 2024
View reviewed changes
docs/features/AnoncredsControllerMigration.md Outdated Show resolved Hide resolved
docs/features/AnoncredsControllerMigration.md Show resolved Hide resolved
jamshale added 2 commits April 29, 2024 18:33
@jamshale
Add anoncreds migration guide
1032661 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale
Update migration guide
571aeee 
Signed-off-by: jamshale <jamiehalebc@gmail.com>
@jamshale jamshale mentioned this pull request Apr 29, 2024
Merged
@dbluhm dbluhm added the 1.0.0 To be addressed for the ACA-Py 1.0.0 release label May 14, 2024
@dbluhm dbluhm requested a review from ianco May 21, 2024 16:04
dbluhm
dbluhm approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as close to the AnonCreds changes of late so it might be valuable to get input from others still but I found this document to be quite thorough and informative and, to my knowledge, accurate.

@jamshale jamshale dismissed ianco’s stale review May 21, 2024 20:38

Should be resolved.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jamshale
Copy link
Contributor Author

I'm not as close to the AnonCreds changes of late so it might be valuable to get input from others still but I found this document to be quite thorough and informative and, to my knowledge, accurate.

👍 I think it's good enough for now. We might need to make changes when people start using it, but we can adjust it then.

@dbluhm dbluhm merged commit 33f1a6e into openwallet-foundation:main May 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran left review comments

@dbluhm dbluhm dbluhm approved these changes

@ianco ianco Awaiting requested review from ianco

Assignees
No one assigned
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .md document for controller upgrade to anoncreds
4 participants
@jamshale @swcurran @ianco @dbluhm