fix: connectionless OOB offers/requests and service parsing #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
I've got some test issues to sort out. Bad mocked values. |
|
ff137
added a commit
to ff137/acapy
that referenced
this pull request
Apr 23, 2024
…ionless-oob-service-parse Signed-off-by: ff137 <ff137@proton.me>
|
Superseded by #2910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2907.
Modifications were made in an earlier PR to the handling of the service decorator which caused some issues in the
OobProcessorwhen it was handling connectionless offers/requests. These issues should now be corrected.It would also seem that connectionless interactions are not covered by our integration tests as a side note. I validated these fixes using this minimal reproducible example setup in my AME repo (committed version is testing against 0.11.0; I ran locally against an image built from main): Indicio-tech/acapy-minimal-example#86
cc: @nodlesh @swcurran