Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interop): overly strict validation #2943

Merged

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented May 10, 2024

This change relaxes some overly strict validation that was preventing presenting proof using LDP-VC from Credo 0.5.X based agents.

@dbluhm
Copy link
Contributor Author

dbluhm commented May 14, 2024

cc @PatStLouis

@PatStLouis
Copy link
Contributor

From the VC specification:

If the id property is present:

The id property MUST express an identifier that others are expected to use when expressing statements about a specific thing identified by that identifier.
The id property MUST NOT have more than one value.
The value of the id property MUST be a URI.

The most relevant here is the last point The value of the id property MUST be a URI.

Instead of testing for UUID, we can test for a URI value. I've commented the PR

@dbluhm
Copy link
Contributor Author

dbluhm commented May 14, 2024

@PatStLouis The id properties changed are in the presentation submission, which is outlined in the presentation exchange specification as follows:

The presentation_submission object MUST contain an id property. The value of this property MUST be a unique identifier, such as a UUID.
The presentation_submission object MUST contain a definition_id property. The value of this property MUST be the id value of a valid Presentation Definition.

I think the only change made to the VC itself is loosening the requirements for the LinkedDataProof schema domain property

@dbluhm dbluhm added the 1.0.0 To be addressed for the ACA-Py 1.0.0 release label May 14, 2024
@PatStLouis
Copy link
Contributor

@dbluhm thanks for the clarification, I misread that this applied to the presentation itself!

This change relaxes some overly strict validation that was preventing
presenting proof using LDP-VC from Credo 0.5.X based agents.

Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm dbluhm force-pushed the fix/interop/overly-strict-validation branch from a97c80b to 29c5468 Compare May 16, 2024 00:25
Copy link

sonarcloud bot commented May 16, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@dbluhm dbluhm enabled auto-merge May 21, 2024 15:57
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dbluhm dbluhm merged commit 0cae003 into openwallet-foundation:main May 21, 2024
8 checks passed
@jamshale jamshale mentioned this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants