-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeCov report on PR's #2950
CodeCov report on PR's #2950
Conversation
I'm not sure who might have access to the old codecov account for this repo? |
I do. @ryjones should too. |
Looking at updating the token. |
Done, |
@jamshale, You might need to push an update to get the new secret to be picket up. It does not exist in the context of the existing action runs, so simply re-running them has no effect. |
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Doh, I know what the issue is. PRs don't have access to the GitHub secrets (at least by default). |
Ok. Ya I'm trying to figure out what to do. Didn't anticipate this problem. |
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Hmm. I tried tokenless upload with v3, which is supposed to work with open source repos. However, I got a 429 error due to rate limiting. I seems like a prevalent problem and the codecov team has an open issue they are working on. I'm not sure if it's possible to get the token working from a forked repo PR. I might try and run it a few more times and see if it works a decent amount of the time. Otherwise I'm not sure what to do, other than wait for them to fix it or possibly switch code coverage reporting providers. |
Quality Gate passedIssues Measures |
I've researched the codecov github action repo quite a bit now and I think it's basically broken for our use case. So many people are reporting the same problems and I have no idea when they are going to fix it. I'm going to figure out an alternative to switch to. Probably |
@jamshale, How about setting up SonarCloud to handle the code coverage as well? It's already running and reporting on the PRs. Additional setup details here; https://docs.sonarsource.com/sonarcloud/enriching/test-coverage/overview/ |
@WadeBarnes I'm still going to look at alternatives because I'm not a big fan of how codecov github actions work for our use case. However, their team did say that we need to install the app to our repo to get our own bandwidth for uploads, and I never mentioned that. codecov/codecov-action#1431 (comment). Not sure if you want to try this, or just continue finding a better option? |
@ryjones, Any opinions? |
I think SonarCloud, if it handles what you need, is better. |
This will bring back
codecov
reporting on PR's and add comments like:The warning only happened because I forced pushed.
The readme badge should also start working again.
There is a bit of setup for the repo admin. I'm hoping the covecov account that was used a year ago can be used again. The repo admin has to setup a token. It's really easy. The instructions are here https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage.
Note: The unit tests for this PR won't pass until the token is available.