Manage integration tests with GitHub Actions (#2952) #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianco
previously approved these changes
May 29, 2024
|
|
@ianco I rebased to fix a merge conflict and need re-approval, please. |
ianco
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes automatic integration testing to have two levels. One will be run on PR's
@PRand another to run once daily, manually triggered or during release PR's@Release. Each test takes, on average, just over one minute. The PR tests were scoped down slightly to 35 tests. Which take ~40 minutes. Most of the tests not running on PR's are doing mediation and multi-tenancy tests on basic connection and issuance tests, because they should be covered by the revocation tests. Also some issuance tests were basically being covered twice.I'm very open to scoping these PR tests even further down. Right now the connections tests are testing a lot of different configurations and this might be unlikely to be effected by many PR's. Also the endorsement tests are a bit flakier than other tests and might not be needed for PR's.
Basically we should only have a bare minimum of tests on PR's because any problems should be noticed via the daily tests and the release tests. If testing all the different connection configurations wasn't needed for PR's we might be able to get this down to 20 tests (~20mins).
There is 62 tests for the Release tag. Increased slight from the old GHA tag.
Added a TODO tag to a couple failing tests.