Use a published version of aiohttp-apispec #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
previously approved these changes
Jun 6, 2024
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
jamshale
force-pushed
the
use-published-aiohttp-spec
branch
from
acb68c6
to
49b480b
Compare
|
I did some updates with the readme file of the forked package and deleted the first version 3.0.1 I did. I should have just left it because you aren't able to publish the same version. So, current version is now 3.0.2. |
|
dbluhm
approved these changes
Jun 6, 2024
EmadAnwer
pushed a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Jun 7, 2024
* Use a published version of aiohttp-apispec Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix lock file Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update version of aiohttp-apispec-acapy Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com> Signed-off-by: EmadAnwer <emadanwer.official@gmail.com>
EmadAnwer
pushed a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Jun 7, 2024
* Use a published version of aiohttp-apispec Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix lock file Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update version of aiohttp-apispec-acapy Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
EmadAnwer
added a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Jun 7, 2024
* Use a published version of aiohttp-apispec Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix lock file Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update version of aiohttp-apispec-acapy Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
EmadAnwer
pushed a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Jun 7, 2024
* Use a published version of aiohttp-apispec Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix lock file Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update version of aiohttp-apispec-acapy Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
EmadAnwer
pushed a commit
to Whats-Cookin/aries-cloudagent-python
that referenced
this pull request
Jun 9, 2024
* Use a published version of aiohttp-apispec Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix lock file Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update version of aiohttp-apispec-acapy Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
ff137
pushed a commit
to ff137/acapy
that referenced
this pull request
Jun 11, 2024
* Use a published version of aiohttp-apispec Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix lock file Signed-off-by: jamshale <jamiehalebc@gmail.com> * Update version of aiohttp-apispec-acapy Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is my idea for the
aiohttp-apispeclibrary. I forked the repo from @ff137 and then published my own pypi library calledaiohttp-apispec-acapy. This isn't really a lot better than downloading it from the forked repo as I could still delete the package. I do think it's a bit safer than using the remote repo and tag.https://pypi.org/project/aiohttp-apispec-acapy/3.0.1/
It would be better if someone with a hyperledger account published it there instead.
I think this is a bit more solid until we come up with a long term migration plan which I think will hold up v1.0.0 release too long.
I'd need to make some adjustments to the readme file and I'm not certain if I should have the original owners information on it.
Just wanted to get others thoughts on this.