fix: respond to did:peer:1 with did:peer:4 #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
force-pushed
the
fix/default-peer-1-response
branch
from
1ca64c1
to
7080d92
Compare
dbluhm
force-pushed
the
fix/default-peer-1-response
branch
from
7080d92
to
23616b5
Compare
|
I tested against Credo and added a quick unit test. All looked good and worked as expected. This should resolve #3020. |
jamshale
approved these changes
Jul 2, 2024
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
dbluhm
force-pushed
the
fix/default-peer-1-response
branch
from
936c5aa
to
f1e1663
Compare
|
Merged
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the default did method ACA-Py will respond to did:peer:1 with to did:peer:4. This should help the situation reported in #3020.
Marked as draft until I have a chance to test against Credo.