Restore --base-wallet-routes flag functionality
#3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esune
force-pushed
the
fix/base-wallet-extra-routes
branch
from
a51f6dd
to
5916c81
Compare
jamshale
reviewed
Nov 21, 2024
jamshale
approved these changes
Nov 21, 2024
|
Thanks @esune! I will test this in the scenario we're using and report back whether it works as expected. |
dbluhm
approved these changes
Nov 22, 2024
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
dbluhm
force-pushed
the
fix/base-wallet-extra-routes
branch
from
1ce3074
to
88be790
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3283
The
tenant_authenticationhas been updated to also allow access to the base wallet when the route matches a path defined using--base-wallet-routes.Please note that, when compared to the previous implementation, the matcher has been made more greedy to tighten security: if an extra route of
/testis specified, the matcher will only match that and not/testAor/test-something-elseas it appears it would have done before.One drawback of having to use this matcher inside the decorator is that I could not think of an elegant way of caching the compiled pattern for reuse - suggestions on how to achieve that, if desirable/required, will be welcome.