Attr support for proof restrictions #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 247 247
Lines 13166 13167 +1
=======================================
+ Hits 12701 12702 +1
Misses 465 465 |
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
|
Hold off on this until Monday please - I'd like to take a deeper look |
|
@sklump I took a crack at updating the schema so we could keep the schema validations on the restrictions however I couldn't get it to work. You can see the updated schema code here: |
sklump
reviewed
Jul 6, 2020
| @@ -206,7 +212,7 @@ class IndyProofReqPredSpecSchema(Schema): | |||
| ) | |||
| p_value = fields.Integer(description="Threshold value", required=True) | |||
| restrictions = fields.List( | |||
| fields.Nested(IndyProofReqSpecRestrictionsSchema()), | |||
| fields.Dict(), # fields.Nested(IndyProofReqSpecRestrictionsSchema()), | |||
There was a problem hiding this comment.
Let me have a crack at it, I am just off vacation and full of hubris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo ian@anon-solutions.ca