Api security #67
Merged
Api security #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
Signed-off-by: Nicholas Rempel <nbrempel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
- Coverage 70.67% 70.58% -0.1%
=========================================
Files 176 177 +1
Lines 7400 7424 +24
=========================================
+ Hits 5230 5240 +10
- Misses 2170 2184 +14 |
andrewwhitehead
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new cli parameters:
--admin-insecure-mode
--admin-api-key
Exactly one of these two parameters are required if --admin is passed.
If an API key is provided, then requests must pass the key in the HTTP header X-API-Key otherwise the request will fail with a 401 response.