-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't extract decorators with names matching the 'data_key' of defined schema fields #85
Don't extract decorators with names matching the 'data_key' of defined schema fields #85
Conversation
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 70.98% 71.02% +0.04%
==========================================
Files 177 177
Lines 7524 7535 +11
==========================================
+ Hits 5341 5352 +11
Misses 2183 2183 |
…fields Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
0b182da
to
5bcddea
Compare
Unless I've misread the intent, this approach still needs about 20 lines of boilerplate per descendant to replace one parameter, skip_attrs, in Could taking skip_attrs into extract_decorators itself, like this:
then in descendant
work OK? Apart from the one line delta, I think the rest of the processing ought to be identical in descendants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me
I will also propagate this change into my Aries#0036 PR by tomorrow morning. |
@sklump I didn't mean to clobber your comment - I do like the idea of keeping things declarative. @andrewwhitehead right now, the intent is that the sub-class of agent_message would override What about something declarative like Stephen's approach, but checking |
It's not meant to be necessary to override |
OK, I will try to get it to work and adapt accordingly by tomorrow morning. |
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've heard good things about this from @ianco and looks OK to me.
@sklump Re: Aries#36 support