fix(js)!: add argon2i(mod|int) support #127
Conversation
Signed-off-by: blu3beri <blu3beri@proton.me>
berendsliedrecht
changed the title
| private argon2Level?: Argon2Level | ||
|
|
||
| public constructor(method: KdfMethod, argon2Level?: Argon2Level) { | ||
| if (method == KdfMethod.Kdf && !argon2Level) { |
There was a problem hiding this comment.
| if (method == KdfMethod.Kdf && !argon2Level) { | |
| if (method === KdfMethod.Kdf && !argon2Level) { |
There was a problem hiding this comment.
Should we add a check if kdf level is Raw and argon2level is defined? Also should we just add more enum values instead? What's the benefit of having kdf and then mod/int instaed of having kdf_mod and kdf_int?
There was a problem hiding this comment.
Mainly did it to be inline with how it is done in askar itself and this allows, although not quite good, more kdfs.
There was a problem hiding this comment.
I will change it to Argon2IMod and Argon2IInt as growing with more kdfs would also not be a breaking change then.
Signed-off-by: blu3beri <blu3beri@proton.me>
Signed-off-by: blu3beri <blu3beri@proton.me>
| export enum KdfMethod { | ||
| Raw = 'raw', | ||
| None = 'none', | ||
| Argon2IMod = 'kdf:argon2i:mod', | ||
| Argon2IInt = 'kdf:argon2i:int', | ||
| } | ||
|
|
||
| export class StoreKeyMethod { | ||
| private method: KdfMethod | ||
|
|
||
| public constructor(method: KdfMethod) { | ||
| this.method = method | ||
| } | ||
|
|
||
| public toUri() { | ||
| return this.method.toString() | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this for future proofing? We could just use the enum value directly right?!
There was a problem hiding this comment.
Yes, it is for future proofing. Argon could have a salt or other kdf methods might need some custom logic.
Signed-off-by: blu3beri blu3beri@proton.me
argon2i