Updates to the README and other Admin files in the repository #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Curran <swcurran@gmail.com>
|
@andrewwhitehead -- note the reference in the readme that link to the indy-wallet documents. Is it safe enough to reference those (with the caveat that I put in) or are we better to leave them off until we get an Askar-specific version of the documents? What's up with this documentation only PR failing tests? :-) |
|
I think it's fine to reference indy-wallet, although the implementation details are not all the same. It's based on the specifications (and reverse engineering) of the indy-wallet format, not the code. |
|
That’s what I was trying to say — sounds like I missed the mark a bit. I’ll look to see if I can make that clearer. |
Signed-off-by: Stephen Curran <swcurran@gmail.com>
|
Updated that phrase. Good enough? |
andrewwhitehead
approved these changes
Jun 29, 2023
jamshale
pushed a commit
to jamshale/askar
that referenced
this pull request
Aug 18, 2024
…-more Updates to the README and other Admin files in the repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Curran swcurran@gmail.com