Add workaround for building ring on aarch64 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
force-pushed
the
fix/build-aarch
branch
2 times, most recently
from
6319a12
to
4c2c8d6
Compare
|
So close…can you make it work for Python too? |
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
fix/build-aarch
branch
from
4c2c8d6
to
9408aea
Compare
|
w00t!!! Can we merge this? @berendsliedrecht @genaris |
|
Nice!!! |
berendsliedrecht
approved these changes
Nov 9, 2023
| # Required for compatibility with manylinux2014: | ||
| # https://github.com/briansmith/ring/issues/1728 | ||
| if [ "${{ matrix.target }}" = "aarch64-linux-android" ]; then | ||
| export CFLAGS="-D__ARM_ARCH=8" |
There was a problem hiding this comment.
Some android devices might still be on 7 IIRC. I strongly doubt this will cause any issues, but just leaving this here if we find issues in the feature regarding Android on ARMv7.
jamshale
pushed a commit
to jamshale/aries-askar
that referenced
this pull request
Aug 18, 2024
…/build-aarch Add workaround for building ring on aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.