fix: remove strict w3c subjectId uri validation (#1805)

Signed-off-by: Martin Auer <martin.auer97@gmail.com>
openwallet-foundation · Mar 28, 2024 · 65f7611 · 65f7611
1 parent 9fb6ae0
commit 65f7611
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/core/src/modules/vc/models/credential/W3cCredentialSubject.ts b/packages/core/src/modules/vc/models/credential/W3cCredentialSubject.ts
@@ -27,7 +27,6 @@ export class W3cCredentialSubject {
     }
   }
 
-  @IsUri()
   @IsOptional()
   public id?: string
 
@@ -70,12 +69,11 @@ export function IsW3cCredentialSubject(validationOptions?: ValidationOptions): P
       name: 'IsW3cCredentialSubject',
       validator: {
         validate: (value): boolean => {
-          return isInstance(value, W3cCredentialSubject) && (!value.id || isUri(value.id))
+          return isInstance(value, W3cCredentialSubject)
         },
         defaultMessage: buildMessage(
           (eachPrefix) =>
-            eachPrefix +
-            '$property must be an object or an array of objects with an optional id property which is an URI',
+            eachPrefix + '$property must be an object or an array of objects with an optional id property',
           validationOptions
         ),
       },

diff --git a/packages/core/src/modules/vc/models/credential/__tests__/W3cCredential.test.ts b/packages/core/src/modules/vc/models/credential/__tests__/W3cCredential.test.ts
@@ -152,7 +152,7 @@ describe('W3cCredential', () => {
         },
         W3cCredential
       )
-    ).toThrow()
+    ).not.toThrow()
 
     expect(() =>
       JsonTransformer.fromJSON(