Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProofProtocolVersion enum in 0.3.0-pre #1056

Closed
TimoGlastra opened this issue Oct 20, 2022 · 6 comments · Fixed by #1062
Closed

Remove ProofProtocolVersion enum in 0.3.0-pre #1056

TimoGlastra opened this issue Oct 20, 2022 · 6 comments · Fixed by #1062
Milestone

Comments

@TimoGlastra
Copy link
Contributor

As they are now dynamically registered, an enum doesn't work. This is also needed to make the credentials and proofs API consistent.

@TimoGlastra
Copy link
Contributor Author

@NB-MikeRichardson is this something you can pick up as well?

@NB-MikeRichardson
Copy link
Contributor

Sure. I can do that today.

I assume we just want to replace the enum with a string?? (which I think is what we do in the credentials module)

@TimoGlastra
Copy link
Contributor Author

For the records, yes it can be a string. For other places it sometimes should be a dynamic type (but I think you already added that in the proofs api when you updated it to align with the credentials api).

We have the ProtocolVersionType in the ProofsApiOptions

@TimoGlastra
Copy link
Contributor Author

Also, I just noticed the requestProof method doesn't specify the proof services, and proof formats, which removes the type hinting. Can you add it with the PR?

In ProofsApi.ts:

public async requestProof(options: RequestProofOptions<PFs, PSs>): Promise<ProofRecord> {

@NB-MikeRichardson
Copy link
Contributor

On it

@TimoGlastra TimoGlastra added this to the v0.3.0 milestone Oct 20, 2022
@NB-MikeRichardson
Copy link
Contributor

Looks like the same issue with proposeProof as well. Will fix this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants