-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ProofProtocolVersion enum in 0.3.0-pre #1056
Comments
@NB-MikeRichardson is this something you can pick up as well? |
Sure. I can do that today. I assume we just want to replace the enum with a string?? (which I think is what we do in the credentials module) |
For the records, yes it can be a string. For other places it sometimes should be a dynamic type (but I think you already added that in the proofs api when you updated it to align with the credentials api). We have the |
Also, I just noticed the In
|
On it |
Looks like the same issue with |
As they are now dynamically registered, an enum doesn't work. This is also needed to make the credentials and proofs API consistent.
The text was updated successfully, but these errors were encountered: