refactor(proofs): remove ProofProtocolVersion enum in 0.3.0-pre #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
NB-MikeRichardson
changed the title
TimoGlastra
approved these changes
Oct 20, 2022
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Codecov Report
@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
- Coverage 88.22% 88.21% -0.01%
==========================================
Files 680 679 -1
Lines 15903 15897 -6
Branches 2570 2569 -1
==========================================
- Hits 14030 14024 -6
Misses 1865 1865
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I have run the failing test locally (using node 14) but it passes on my machine. Is there anything we can do to fix this or should we merge anyway? tenants/tests/tenant-sessions.e2e.test.ts |
|
Can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Richardson mike.richardson@ontario.ca