fix: unable to resolve nodejs document loader in react native environment #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimStekelenburg
changed the title
karimStekelenburg
changed the title
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #1003 +/- ##
=============================================
+ Coverage 87.82% 87.84% +0.01%
=============================================
Files 615 615
Lines 14772 14763 -9
Branches 2500 2495 -5
=============================================
- Hits 12974 12969 -5
+ Misses 1700 1696 -4
Partials 98 98
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
genaris
reviewed
Sep 1, 2022
TimoGlastra
reviewed
Sep 8, 2022
Signed-off-by: Karim Stekelenburg <karim@animo.id>
Signed-off-by: Karim Stekelenburg <karim@animo.id>
Signed-off-by: Karim Stekelenburg <karim@animo.id>
Signed-off-by: Karim Stekelenburg <karim@animo.id>
karimStekelenburg
force-pushed
the
993-unable-to-resolved-https-module-in-react-native
branch
from
bfd2661
to
011a9fc
Compare
TimoGlastra
approved these changes
Sep 9, 2022
TimoGlastra
changed the title
TimoGlastra
deleted the
993-unable-to-resolved-https-module-in-react-native
branch
genaris
pushed a commit
to 2060-io/aries-framework-javascript
that referenced
this pull request
Sep 16, 2022
…ment (openwallet-foundation#1003) Signed-off-by: Karim Stekelenburg <karim@animo.id> Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Artemkaaas
added a commit
to sicpa-dlab/aries-framework-javascript
that referenced
this pull request
Sep 29, 2022
…-did-package openwallet-foundation#1003/Add separate `peer-did-ts` package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993 by conditionally importing the XHR and NodeJS document loaders, based on the runtime environment.