feat: add getRequestedCredentialsForProofRequest #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #1028 +/- ##
==========================================
Coverage 88.23% 88.23%
==========================================
Files 637 637
Lines 15092 15096 +4
Branches 2542 2542
==========================================
+ Hits 13316 13320 +4
Misses 1678 1678
Partials 98 98
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TimoGlastra
reviewed
Sep 18, 2022
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
|
Comments resolved, a new e2e test added, yarn.lock corrected. |
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
TimoGlastra
approved these changes
Sep 21, 2022
genaris
pushed a commit
to 2060-io/aries-framework-javascript
that referenced
this pull request
Oct 13, 2022
…foundation#1028) Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method getRequestedCredentialsForProofRequest was present in the API before the PPV2 code was merged but somehow got lost.
It has been restored in this PR