ci: use graph-type all for lerna publish #1084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CD is broken since #1082 has been merged, and it seems that it's because lerna is using alphabetical order when publishing packages (
lerna publish
command), so attempts to build action-menu before core (marked as peerDependency).According to Lerna Publish documentation, this is because lerna uses by default a
dependencies
graph-type, which will take into account only packages listed in dependencies to determine the build order. As in this case it is listed in peerDependencies, anall
graph-type must be used.Another option of course would be to modify action-menu's package.json to set core as a direct dependency. However, this would be also needed for any other package that comes before to core in alphabetical order (such as
bbs-signatures
). I'm not sure if this would be conceptually correct (this was discussed recently when extracting BBS module).