Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow to connect with self #1173

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Dec 16, 2022

This was previously possible in 0.1.0, but broken in 0.2.0. This allows to connect to yourelf using connections protocols and didexchange protocol

BREAKING CHANGE: the didRecord.id was previously the did iteself. However to allow for connecting with self, where multiple did records are created for the same did, the id property is now an uuid and a separate did property is added. A migration script has been provided to update all did record's ids

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner December 16, 2022 10:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #1173 (ee27d61) into main (c0569b8) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   88.82%   88.81%   -0.02%     
==========================================
  Files         706      707       +1     
  Lines       16536    16571      +35     
  Branches     2805     2808       +3     
==========================================
+ Hits        14688    14717      +29     
- Misses       1739     1744       +5     
- Partials      109      110       +1     
Impacted Files Coverage Δ
...ore/src/modules/connections/DidExchangeProtocol.ts 86.89% <ø> (ø)
...re/src/modules/dids/methods/key/KeyDidRegistrar.ts 96.29% <ø> (ø)
.../src/modules/dids/methods/peer/PeerDidRegistrar.ts 98.03% <ø> (ø)
...modules/dids/methods/sov/IndySdkSovDidRegistrar.ts 94.20% <ø> (ø)
.../modules/connections/services/ConnectionService.ts 88.36% <40.00%> (-0.24%) ⬇️
.../core/src/modules/dids/repository/DidRepository.ts 65.21% <50.00%> (-11.26%) ⬇️
packages/core/src/modules/oob/OutOfBandApi.ts 86.44% <60.00%> (ø)
...e/src/modules/dids/methods/peer/PeerDidResolver.ts 79.31% <66.66%> (-2.18%) ⬇️
...s/connections/handlers/ConnectionRequestHandler.ts 86.66% <75.00%> (ø)
.../connections/handlers/DidExchangeRequestHandler.ts 80.00% <75.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra TimoGlastra changed the title feat: allow to connect with self feat!: allow to connect with self Dec 19, 2022
Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this feature back!

@TimoGlastra TimoGlastra merged commit 7781a55 into openwallet-foundation:main Dec 20, 2022
@TimoGlastra TimoGlastra deleted the feat/allow-to-connect-with-self branch December 20, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants