Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding trust ping events and trust ping command #1182

Merged

Conversation

KimEbert42
Copy link
Contributor

Signed-off-by: Kim Ebert kim@indicio.tech

Signed-off-by: Kim Ebert <kim@indicio.tech>
@KimEbert42 KimEbert42 requested a review from a team as a code owner December 22, 2022 21:17
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @reflectivedevelopment!

Could you fix the prettier and eslint errors? Most can be fixed by running yarn lint --fix. Also could you add a test that sends a trust ping to another agent, and another agent responding with a response and also checking whether the events are received?

packages/core/src/modules/connections/ConnectionsApi.ts Outdated Show resolved Hide resolved
packages/core/src/modules/connections/ConnectionsApi.ts Outdated Show resolved Hide resolved
packages/core/src/modules/connections/ConnectionsApi.ts Outdated Show resolved Hide resolved
packages/core/src/modules/connections/ConnectionsApi.ts Outdated Show resolved Hide resolved
packages/core/src/modules/connections/TrustPingEvents.ts Outdated Show resolved Hide resolved
packages/core/src/modules/connections/TrustPingEvents.ts Outdated Show resolved Hide resolved
packages/core/src/modules/connections/TrustPingEvents.ts Outdated Show resolved Hide resolved
packages/core/src/modules/connections/ConnectionsApi.ts Outdated Show resolved Hide resolved
Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #1182 (7575baa) into main (59d1982) will increase coverage by 0.07%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
+ Coverage   88.82%   88.90%   +0.07%     
==========================================
  Files         707      708       +1     
  Lines       16593    16614      +21     
  Branches     2804     2809       +5     
==========================================
+ Hits        14739    14770      +31     
+ Misses       1744     1736       -8     
+ Partials      110      108       -2     
Impacted Files Coverage Δ
...ges/core/src/modules/connections/ConnectionsApi.ts 84.82% <77.77%> (-0.47%) ⬇️
...es/core/src/modules/connections/TrustPingEvents.ts 100.00% <100.00%> (ø)
packages/core/src/modules/connections/index.ts 100.00% <100.00%> (ø)
...c/modules/connections/services/TrustPingService.ts 100.00% <100.00%> (+33.33%) ⬆️
...ctions/handlers/TrustPingResponseMessageHandler.ts 100.00% <0.00%> (+28.57%) ⬆️
...s/connections/messages/TrustPingResponseMessage.ts 93.33% <0.00%> (+46.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final nits

KimEbert42 and others added 3 commits January 7, 2023 08:16
Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
@TimoGlastra TimoGlastra enabled auto-merge (squash) January 9, 2023 05:22
@TimoGlastra
Copy link
Contributor

Thanks @reflectivedevelopment!

@TimoGlastra TimoGlastra merged commit fd006f2 into openwallet-foundation:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants