-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding trust ping events and trust ping command #1182
feat: adding trust ping events and trust ping command #1182
Conversation
Signed-off-by: Kim Ebert <kim@indicio.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @reflectivedevelopment!
Could you fix the prettier and eslint errors? Most can be fixed by running yarn lint --fix
. Also could you add a test that sends a trust ping to another agent, and another agent responding with a response and also checking whether the events are received?
packages/core/src/modules/connections/services/TrustPingService.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
Codecov Report
@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
+ Coverage 88.82% 88.90% +0.07%
==========================================
Files 707 708 +1
Lines 16593 16614 +21
Branches 2804 2809 +5
==========================================
+ Hits 14739 14770 +31
+ Misses 1744 1736 -8
+ Partials 110 108 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final nits
packages/core/src/modules/connections/services/TrustPingService.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/connections/services/TrustPingService.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
Thanks @reflectivedevelopment! |
Signed-off-by: Kim Ebert kim@indicio.tech