Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indy-vdr): use @hyperledger packages #1252

Merged

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Feb 1, 2023

Waiting for the release of 0.1.0-dev.4 (hyperledger/indy-vdr#150) for response type fixing.

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner February 1, 2023 21:11
@genaris genaris linked an issue Feb 1, 2023 that may be closed by this pull request
@genaris genaris marked this pull request as draft February 1, 2023 21:41
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Heads up on this one @Vickysomtee. After this is merged you'd need to update all imports to use @hyperledger/indy-vdr- instead of indy-vdr-test-

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris marked this pull request as ready for review February 2, 2023 13:21
@genaris genaris enabled auto-merge (squash) February 2, 2023 13:23
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #1252 (ca83df4) into main (b5eb08e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1252   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files         760      760           
  Lines       18149    18149           
  Branches     3081     3081           
=======================================
  Hits        15854    15854           
  Misses       2288     2288           
  Partials        7        7           
Impacted Files Coverage Δ
...ackages/indy-vdr/src/dids/IndyVdrSovDidResolver.ts 92.10% <100.00%> (ø)
packages/indy-vdr/src/index.ts 75.00% <100.00%> (ø)
packages/indy-vdr/src/pool/IndyVdrPool.ts 85.96% <100.00%> (ø)
packages/indy-vdr/src/pool/IndyVdrPoolService.ts 74.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@genaris genaris merged commit acdb20a into openwallet-foundation:main Feb 2, 2023
@genaris genaris deleted the feat/use-hiperledger-indy-vdr branch February 19, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update indy-vdr package to @hyperledger/indy-vdr-* pacakges
3 participants