Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return http 415 if unsuporrted content type #1313

Merged
merged 9 commits into from
Mar 11, 2023
Merged

fix: return http 415 if unsuporrted content type #1313

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ebb06c
fix: return http 415 if unsuporrted content type
TimoGlastra Feb 17, 2023
85a52d8
Merge branch 'main' into fix/content-type-error-response
genaris Feb 17, 2023
dd4917d
Merge branch 'main' into fix/content-type-error-response
genaris Feb 18, 2023
04d99ed
Merge branch 'main' into fix/content-type-error-response
genaris Feb 18, 2023
9c86686
Merge branch 'main' into fix/content-type-error-response
genaris Feb 18, 2023
da59c05
Merge branch 'main' into fix/content-type-error-response
genaris Feb 24, 2023
0298f68
Merge branch 'main' into fix/content-type-error-response
TimoGlastra Feb 28, 2023
6847095
Merge remote-tracking branch 'upstream/main' into fix/content-type-er…
TimoGlastra Mar 11, 2023
3839303
fix
TimoGlastra Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions packages/node/src/transport/HttpInboundTransport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import type { Server } from 'http'
import { DidCommMimeType, AriesFrameworkError, TransportService, utils, MessageReceiver } from '@aries-framework/core'
import express, { text } from 'express'

const supportedContentTypes: string[] = [DidCommMimeType.V0, DidCommMimeType.V1]

export class HttpInboundTransport implements InboundTransport {
public readonly app: Express
private port: number
Expand All @@ -22,12 +24,19 @@ export class HttpInboundTransport implements InboundTransport {
this.app = app ?? express()
this.path = path ?? '/'

this.app.use(
text({
type: [DidCommMimeType.V0, DidCommMimeType.V1],
limit: '5mb',
})
)
this.app.use((req, res, next) => {
const contentType = req.headers['content-type']

if (!contentType || !supportedContentTypes.includes(contentType)) {
return res
.status(415)
.send('Unsupported content-type. Supported content-types are: ' + supportedContentTypes.join(', '))
}

return next()
})

this.app.use(text({ type: supportedContentTypes, limit: '5mb' }))
}

public async start(agent: Agent) {
Expand Down