Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Emit RoutingCreated event for mediator routing record #1445

Merged
merged 1 commit into from
May 3, 2023
Merged

fix: Emit RoutingCreated event for mediator routing record #1445

merged 1 commit into from
May 3, 2023

Conversation

AlexanderShenshin
Copy link
Contributor

Added RoutingCreatedEvent emit after creation of mediator routing record in MediatorService.

This change is required to enable mediator functionality for tenant agents as registerRecipientKeyForTenant will not be called for mediator routing key otherwise (done in RoutingCreatedEvent listener).

@AlexanderShenshin AlexanderShenshin requested a review from a team as a code owner May 1, 2023 11:39
@AlexanderShenshin
fix: Emit RoutingCreated event for mediator routing record
8ce4dc5 
Signed-off-by: alexander.shenshin <alexander.shenshin@dsr-corporation.com>
TimoGlastra
TimoGlastra reviewed May 1, 2023
View reviewed changes
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget my comment, i misunderstood the PR

@TimoGlastra
Copy link
Contributor

TimoGlastra commented May 1, 2023 •
edited
Loading

Do we want tenants to act as mediators? Do you have a specific use case?

This can have impact on quite some other areas. And there's other places in the codebase that are going to break when tenants act as mediators. It was specifically left out of scope due to it's limited applicability.

@AlexanderShenshin
Copy link
Contributor Author

Yes, we have a use case where we want to use mediator functionality in multi-tenancy mode.

It seems that in multi-tenancy mode it's not possible to normally use root agent as a mediator because of how TenantAgentContextProvider resolves context for inbound message (it will not find agent context for root agent as it does not have tenant routing record). So we decided to create a separate tenant agent for mediator functionality and it also seems to be more appropriate with current API.

We actually use this change in our project with patch-package as a quick fix for now. It works fine so far, so we would like to keep this approach for now. But thanks for clarification, we will keep possible issues in mind.

@TimoGlastra TimoGlastra enabled auto-merge (squash) May 3, 2023 06:40
@TimoGlastra TimoGlastra merged commit 4145957 into openwallet-foundation:main May 3, 2023
TimoGlastra added a commit that referenced this pull request May 16, 2023
@TimoGlastra @karimStekelenburg
@genaris @jimezesinachi @ryjones @dependabot @KimEbert42 @GramThanos @github-actions @Vickysomtee @KolbyRKunz @berendsliedrecht @jleach @auer-martin @niall-shaw @Zzocker @morrieinmaas @NB-MikeRichardson @Amit-Padmani @DaevMithran @AlexanderShenshin
feat: DIDComm V2 messaging support (#1458)
d6e2b67 
Co-authored-by: Karim Stekelenburg <karim@animo.id>
Co-authored-by: Ariel Gentile <gentilester@gmail.com>
Co-authored-by: Timo Glastra <timo@animo.id>
Co-authored-by: Jim Ezesinachi <ezesinachijim@gmail.com>
Co-authored-by: Ry Jones <ry@linux.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kim Ebert <kim@developmint.work>
Co-authored-by: Grammatopoulos Athanasios Vasileios <GramThanos@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Victor Anene <62852943+Vickysomtee@users.noreply.github.com>
Co-authored-by: Jim Ezesinachi <jim@animo.id>
Co-authored-by: KolbyRKunz <KolbyKunz@yahoo.com>
Co-authored-by: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com>
Co-authored-by: Jason C. Leach <jason.leach@fullboar.ca>
Co-authored-by: Martin Auer <martin.auer97@gmail.com>
Co-authored-by: Niall Shaw <100220424+niall-shaw@users.noreply.github.com>
Co-authored-by: Pritam Singh <43764373+Zzocker@users.noreply.github.com>
Co-authored-by: Mo <10432473+morrieinmaas@users.noreply.github.com>
Co-authored-by: NB-MikeRichardson <93971245+NB-MikeRichardson@users.noreply.github.com>
Co-authored-by: Amit-Padmani <106090107+Amit-Padmani@users.noreply.github.com>
Co-authored-by: DaevMithran <61043607+DaevMithran@users.noreply.github.com>
Co-authored-by: Alexander Shenshin <93187809+AlexanderShenshin@users.noreply.github.com>
fix(openid4vc-client): set package to private (#1210)
fix: fix typing issues with typescript 4.9 (#1214)
Fixes #1205
resolver (#1247)
fix: set updateAt on records when updating a record (#1272)
fix(transport)!: added docs moved connection to connectionId (#1222)
fix(indy-vdr): export relevant packages from root (#1291)
fix(askar): generate nonce suitable for anoncreds (#1295)
resolver and registrar for did:indy (#1253)
fix: imports from core (#1303)
fix: thread id improvements (#1311)
fix: loosen base64 validation (#1312)
fix(samples): dummy module response message type (#1321)
fix: seed and private key validation and return type in registrars (#1324)
fix!: don't emit legacy did:sov prefix for new protocols (#1245)
fix(askar): anoncrypt messages unpacking (#1332)
fix: expose indy pool configs and action menu messages (#1333)
fix: create new socket if socket state is 'closing' (#1337)
fix(anoncreds): include prover_did for legacy indy (#1342)
fix(indy-sdk): import from core (#1346)
fix(anoncreds-rs): save revocation registry index (#1351)
fix: isNewSocket logic (#1355)
fix(tenant): Correctly configure storage for multi tenant agents (#1359)
Fixes hyperledger#1353
fix(anoncreds): Buffer not imported from core (#1367)
fix(core): repository event when calling deleteById (#1356)
fix(askar): custom error handling (#1372)
fix: return HTTP 415 if unsupported content type (#1313)
fix: remove named capture groups (#1378)
fix example usage of indy-sdk-react-native package (#1382)
fix: connection id in sessions for new connections (#1383)
fix: did cache key not being set correctly (#1394)
fix: incorrect type for anoncreds registration (#1396)
fix: reference to indyLedgers in IndyXXXNotConfiguredError (#1397)
fix: add reflect-metadata (#1409)
fix: various anoncreds revocation fixes (#1416)
fix: jsonld credential format identifier version (#1412)
fix: remove `deleteOnFinish` and added documentation (#1418)
fix(askar): default key derivation method (#1420)
fix(anoncreds): make revocation status list inline with the spec (#1421)
fix(anoncreds-rs): revocation status list as JSON (#1422)
fix: issuance with unqualified identifiers (#1431)
fix(connections): store imageUrl when using DIDExchange (#1433)
fix(indy-vdr): do not force indy-vdr version (#1434)
fix: small issues with migration and WAL files (#1443)
fix: migration of link secret (#1444)
fix: Emit RoutingCreated event for mediator routing record (#1445)
fix: small updates to cheqd module and demo (#1439)
fix: remove scope check from response (#1450)
@AlexanderShenshin AlexanderShenshin deleted the fix-tenant-agent-mediator branch August 24, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderShenshin @TimoGlastra