-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AnonCreds proof requests with unqualified dids #1891
fix: AnonCreds proof requests with unqualified dids #1891
Conversation
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
cc @bryce-mcmath @wadeking98 hopefully this can solve the remaining issues with that awful thing popularly known as 'unqualified hell'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another great fix, thanks @genaris!
Do we need a simple test to cover this? (I'm fine with merging it as is to get it fixed ASAP)
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
I've added some based on I'd like to wait for @bryce-mcmath feedback before merging, to make sure we are handling all relevant cases. |
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Following issues found during integration with BCGov Wallet, where AnonCreds with unqualified identifiers are being used, here we try to adjust the identifiers used in a Present Proof flow depending on the proof request contents.
Basically, we analyze whether there is any restriction that contains an unqualified did and, if true, assume that we should use unqualified identifiers. Otherwise, we use the default ones (qualified).
I'm testing with BCGov wallet's main branch in both verifier and holder side and seems to work fine (at least with a basic presentation request using Person credential from BC Wallet Showcase.