refactor: extract inbound transporter from agent constructor #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
TimoGlastra
approved these changes
Apr 15, 2021
| return this.inboundTransporter.start(this) | ||
| if (this.inboundTransporter) { | ||
| await this.inboundTransporter.start(this) | ||
| } |
There was a problem hiding this comment.
Maybe we should log a warning for both the inbound/outbound transporter if they are not set at initialization yet. Just for information
There was a problem hiding this comment.
Hmm, actually I can imagine it's not a problem not having an inbound transported set. But at least the info could be good. For example, I run AFJ as a mediator with Nest.js framework and it's quite convenient I don't have to set inbound transport but I handle it by myself.
|
Please merge my other PR #244 first. Otherwise I need to do quite some manual work again |
Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
Signed-off-by: Jakub Koci <jakub.koci@gmail.com>
genaris
pushed a commit
to genaris/credo-ts
that referenced
this pull request
Apr 24, 2021
…let-foundation#245) BREAKING CHANGE Signed-off-by: Jakub Koci jakub.koci@gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It aligns API with the setting of the outbound transporter. It's also better for the cases when a developer wants to pass messages into the agent by themself.
BREAKING CHANGE
Signed-off-by: Jakub Koci jakub.koci@gmail.com