Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: present proof v2 #666

Merged
merged 136 commits into from
May 19, 2022
Merged

feat: present proof v2 #666

merged 136 commits into from
May 19, 2022

Conversation

NB-PrasadKatkar
Copy link
Contributor

Worked on Present Proof V2 to work with Indy credentials

  • refactor V1 service and some methods of V2 service
  • IndyFormatService to work for indy format
  • wrote e2e test and unit test for Proposal and Proof Request for V1 and V2

NB-PrasadKatkar and others added 30 commits December 14, 2021 18:27
@NB-PrasadKatkar
refactor: initial proof module directory for v1 and v2
8690411 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
feat(PresentProofV2): implemented presentation proposal
a25c14a 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
feat: present proof v2(work in progress)
ccb0329 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
feat: Present Proof v2 (WIP Accept Proposal)
1634262 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-KarimStekelenburg
refactor(proofs): reworked directory structure
d654752 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-PrasadKatkar
Merge branch 'feat/present-proof-v2' of https://github.com/hyperledge…
9866b56 
…r/aries-framework-javascript into hyperledger-feat/present-proof-v2
@NB-PrasadKatkar
Merge branch 'hyperledger-feat/present-proof-v2' into feat/present-pr…
c2d0c45 
…oof-v2
@NB-PrasadKatkar
IndyProofFormatService(Request and Presentation)
9d7a58a 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
fix: IndyProofFormatService, V1ProofService
4de4303 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
refac: IndyProofFormatService, V1ProofService
1f8b369 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-KarimStekelenburg
feat(proofs): add v2 message types
20a8da6 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-PrasadKatkar
refac: V1ProofService
1b52eaa 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-KarimStekelenburg
feat(proofs): add v2 message types
7a021da 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
fix(proofs): add missing goal_code to options
bf824d4 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
feat(proofs): add getter methods to ProofService
84a2f47 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
Merge branch 'feat/present-proof-v2' of https://github.com/hyperledge…
4a201c1 
…r/aries-framework-javascript into feat/present-proof-v2
@NB-PrasadKatkar
refac: V1ProofService
7e03954 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-KarimStekelenburg
feat(proofs): add v2 message types
8c9db7d 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
fix(proofs): add missing goal_code to options
c5d0ec6 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
feat(proofs): add getter methods to ProofService
73d9f5e 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-PrasadKatkar
Merge pull request #3 from hyperledger/feat/present-proof-v2
9d8791a 
Feat/present proof v2
@NB-KarimStekelenburg
Merge branch 'feat/present-proof-v2' of https://github.com/hyperledge…
66c146e 
…r/aries-framework-javascript into feat/present-proof-v2
@NB-KarimStekelenburg
Merge branch 'main' into feat/present-proof-v2
c55c4d6
@NB-PrasadKatkar
refac: ProofsModule
50481a4 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
Merge pull request #4 from hyperledger/feat/present-proof-v2
7eccd99 
Feat/present proof v2
@NB-PrasadKatkar
refac: ProofsModule
68afa1b 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-KarimStekelenburg
feat(didcomm-msg): add find method repositoty
ade451b 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
feat(proofs): update V1 service w/ DidCommMessages
e1c56da 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
refactor(proofs): clean V1Service imports
ae3665e 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-KarimStekelenburg
refactor(proofs): clean V1Service imports
cfe6025 
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
@NB-PrasadKatkar
fix: service name updation comments resolved
cfb8dca 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
fix: eslint fixes
7cb29de 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
fix: some review comments on based on protocol version
0c0feed 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
fix: few comments related to tests
6ba43f2 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
fix: created single file for problem report reason and renamed attchI…
f43f8c8 
…d to id

Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
39514ba 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
fix: removed duplicate referent method
b6cc5d1 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
fix: remove uuid and used indy wallet for nonce generation
b7f0548 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
TimoGlastra and others added 6 commits May 9, 2022 21:27
@TimoGlastra
Update packages/core/src/modules/proofs/ProofService.ts
d04598e 
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Update packages/core/src/modules/proofs/__tests__/V1ProofService.test.ts
7a6fb59 
Signed-off-by: Timo Glastra <timo@animo.id>
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
8bba6dd 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
Merge branch 'feat/present-proof-v2' of https://github.com/NB-PrasadK…
cad0d1f 
…atkar/aries-framework-javascript into feat/present-proof-v2
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
6e40192 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
c59d670 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
cf500e9 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
9b116a9 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
fix: eslint fixes
c8617e4 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
cfde215 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
refac: validate attachment before processing the messages.
de30117 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@NB-PrasadKatkar
Merge branch 'main' of https://github.com/NB-PrasadKatkar/aries-frame…
61797ff 
…work-javascript into feat/present-proof-v2
@NB-PrasadKatkar
tests: presentation exchange unit test
0166af3 
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
@TimoGlastra TimoGlastra added this to the v0.2.0 milestone May 19, 2022
TimoGlastra
TimoGlastra reviewed May 19, 2022
View reviewed changes
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some additional comments, but I think we're almost there. What I'd like to propose is to merge this PR into the feat/ppv2 branch. The additional comments can be resolved in PRs to that branch as it's not manageable anymore to keep working from this PR.

@NB-PrasadKatkar what do you think?

packages/core/src/modules/proofs/ProofService.ts Show resolved Hide resolved
packages/core/src/modules/proofs/ProofsModule.ts Show resolved Hide resolved
packages/core/src/modules/proofs/ProofsModule.ts Show resolved Hide resolved
packages/core/src/modules/proofs/ProofsUtil.ts Show resolved Hide resolved
packages/core/src/modules/proofs/ProofsUtil.ts Show resolved Hide resolved
packages/core/src/modules/proofs/protocol/v2/handlers/V2ProposePresentationHandler.ts Show resolved Hide resolved
packages/core/src/modules/proofs/protocol/v2/handlers/V2RequestPresentationHandler.ts Show resolved Hide resolved
packages/core/src/modules/proofs/protocol/v2/messages/V2PresentationAckMessage.ts Show resolved Hide resolved
packages/core/src/modules/proofs/protocol/v2/messages/V2RequestPresentationMessage.ts Show resolved Hide resolved
packages/core/src/modules/proofs/repository/PresentationExchangeRecord.ts Show resolved Hide resolved
@TimoGlastra TimoGlastra changed the base branch from main to feat/ppv2 May 19, 2022 18:54
@TimoGlastra TimoGlastra dismissed stale reviews from berendsliedrecht, karimStekelenburg, and themself May 19, 2022 18:54

.

@TimoGlastra TimoGlastra merged commit f0e02eb into openwallet-foundation:feat/ppv2 May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianorwhatever brianorwhatever brianorwhatever left review comments

@TimoGlastra TimoGlastra TimoGlastra left review comments

@karimStekelenburg karimStekelenburg Awaiting requested review from karimStekelenburg

@berendsliedrecht berendsliedrecht Awaiting requested review from berendsliedrecht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Adopt RFC 0592: Indy Attachment Format
7 participants
@NB-PrasadKatkar @codecov-commenter @TimoGlastra @brianorwhatever @karimStekelenburg @berendsliedrecht @NB-KarimStekelenburg