-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: do not add ~service in createOOBOffer method #772
refactor: do not add ~service in createOOBOffer method #772
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
@NB-MikeRichardson please take a look at the changes, this touches the credentials module |
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
==========================================
+ Coverage 87.59% 87.61% +0.02%
==========================================
Files 437 437
Lines 10806 10779 -27
Branches 1900 1892 -8
==========================================
- Hits 9465 9444 -21
+ Misses 1279 1273 -6
Partials 62 62
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, just two code cleanup things.
Signed-off-by: Timo Glastra <timo@animo.id>
When calling createOutOfBand offer and then attaching it to the oob invitation would create two set of keys. To overcome this the creating of an offer does not create the keys for the exchange anymore. Instead you just get the message that is not associated with a connection yet. Then you can:
BREAKING CHANGE: with the addition of the out of band module
credentials.createOutOfBandOffer
is renamed tocredentials.createOffer
and no longer adds the~service
decorator to the message. You need to calloob.createLegacyConnectionlessInvitation
afterwards to use it for AIP-1 style connectionless exchanges. See Migrating from AFJ 0.1.0 to 0.2.x for detailed migration instructions.