docs: fix demo for oob #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <timo@animo.id>
33 tasks
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 435 435
Lines 10670 10670
Branches 1891 1891
=======================================
Hits 9340 9340
Misses 1268 1268
Partials 62 62 Continue to review full report at Codecov.
|
berendsliedrecht
approved these changes
May 23, 2022
| throw Error(redText(Output.MissingConnectionRecord)) | ||
| } | ||
|
|
||
| const [connection] = await this.agent.connections.findAllByOutOfBandId(this.outOfBandId) |
There was a problem hiding this comment.
This looks to me like we want a find single in the public api aswell.
There was a problem hiding this comment.
Well there could be multiple, so not sure we should add that method. For demo purposes it's fine to pick the first one I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timo Glastra timo@animo.id