refactor(credentials): minor refactor of CredentialMessageBuilder #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <berend@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #797 +/- ##
==========================================
+ Coverage 87.61% 87.70% +0.08%
==========================================
Files 438 438
Lines 10838 10816 -22
Branches 1904 1893 -11
==========================================
- Hits 9496 9486 -10
+ Misses 1280 1268 -12
Partials 62 62
Continue to review full report at Codecov.
|
TimoGlastra
requested changes
May 25, 2022
packages/core/src/modules/credentials/protocol/v2/CredentialMessageBuilder.ts
Outdated
Show resolved
Hide resolved
…ssageBuilder.ts Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com>
TimoGlastra
approved these changes
May 25, 2022
TimoGlastra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CredentialMesssageBuildera small bitSigned-off-by: Berend Sliedrecht berend@animo.id