fix(credentials): add missing issue credential v1 proposal attributes #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
Signed-off-by: Mike Richardson <mike.richardson@northernblock.io>
TimoGlastra
reviewed
May 25, 2022
packages/core/src/modules/credentials/__tests__/V1CredentialService.propose.offer.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/credentials/__tests__/V1CredentialService.propose.offer.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/credentials/__tests__/V2CredentialService.offer.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/credentials/protocol/v1/V1CredentialService.ts
Show resolved
Hide resolved
TimoGlastra
changed the title
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
TimoGlastra
reviewed
May 26, 2022
packages/core/src/modules/credentials/__tests__/V1CredentialServiceProposeOffer.test.ts
Outdated
Show resolved
Hide resolved
| const { message: credentialProposal } = await credentialService.createProposal(proposeOptions) | ||
|
|
||
| // console.log(credentialProposal.toJSON()) | ||
| expect(credentialProposal.toJSON()).toMatchObject({ |
…rviceProposeOffer.test.ts Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra
approved these changes
May 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #798 +/- ##
==========================================
- Coverage 87.61% 87.61% -0.01%
==========================================
Files 438 438
Lines 10839 10838 -1
Branches 1905 1904 -1
==========================================
- Hits 9497 9496 -1
Misses 1280 1280
Partials 62 62
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.