Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): only send 500 if no headers sent yet #857

Merged
merged 2 commits into from
Jun 15, 2022
Merged

fix(node): only send 500 if no headers sent yet #857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb83350
fix(node): only send 500 if noheaders sent yet
TimoGlastra Jun 15, 2022
504d93a
Merge branch 'main' into fix/http-inbound
TimoGlastra Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/node/src/transport/HttpInboundTransport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ export class HttpInboundTransport implements InboundTransport {
}
} catch (error) {
config.logger.error(`Error processing inbound message: ${error.message}`, error)
res.status(500).send('Error processing message')

if (!res.headersSent) {
res.status(500).send('Error processing message')
}
} finally {
transportService.removeSession(session)
}
Expand Down