Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add base agent class #922

Merged

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Jul 3, 2022

This is the same PR as #919 , but based off the 0.3.0-pre branch instead of main. There's no changes compared to #919

Dependant on:

Signed-off-by: Timo Glastra timo@animo.id

@TimoGlastra TimoGlastra added the multitenancy Tasks related to multi-tenancy label Jul 3, 2022
@TimoGlastra TimoGlastra requested a review from a team as a code owner July 3, 2022 12:12
@codecov-commenter
Copy link

Codecov Report

Merging #922 (ab1d296) into 0.3.0-pre (938a889) will increase coverage by 0.15%.
The diff coverage is 87.43%.

@@              Coverage Diff              @@
##           0.3.0-pre     #922      +/-   ##
=============================================
+ Coverage      86.51%   86.67%   +0.15%     
=============================================
  Files            512      518       +6     
  Lines          12468    12593     +125     
  Branches        2103     2136      +33     
=============================================
+ Hits           10787    10915     +128     
+ Misses          1585     1583       -2     
+ Partials          96       95       -1     
Impacted Files Coverage Δ
packages/core/src/agent/AgentConfig.ts 90.16% <ø> (-0.47%) ⬇️
packages/core/src/agent/Events.ts 100.00% <ø> (ø)
packages/core/src/constants.ts 100.00% <ø> (ø)
...les/credentials/formats/CredentialFormatService.ts 100.00% <ø> (ø)
...cation/handlers/V1RevocationNotificationHandler.ts 71.42% <ø> (ø)
...cation/handlers/V2RevocationNotificationHandler.ts 71.42% <ø> (ø)
...ges/core/src/modules/credentials/services/index.ts 100.00% <ø> (ø)
...ore/src/modules/dids/methods/web/WebDidResolver.ts 60.00% <ø> (ø)
...c/modules/routing/handlers/MediationDenyHandler.ts 62.50% <0.00%> (+6.94%) ⬆️
packages/core/src/storage/migration/updates.ts 100.00% <ø> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938a889...ab1d296. Read the comment docs.

@TimoGlastra TimoGlastra changed the title refactor!: add agent context feat: add base agent class Jul 5, 2022
@berendsliedrecht
Copy link
Contributor

Just started reviewing it but I noticed that all the agentContext additions are in here aswell. I can review it again when #920 is merged into 0.3.0-pre to make life a bit easier.

(FYI, #920 is approved.)

Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@karimStekelenburg karimStekelenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimoGlastra TimoGlastra merged commit 96c5ef8 into openwallet-foundation:0.3.0-pre Jul 8, 2022
TimoGlastra added a commit that referenced this pull request Aug 11, 2022
Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra added a commit that referenced this pull request Aug 26, 2022
Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra added a commit that referenced this pull request Aug 26, 2022
Signed-off-by: Timo Glastra <timo@animo.id>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multitenancy Tasks related to multi-tenancy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants