feat: add present proof v2 #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
…r/aries-framework-javascript into hyperledger-feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
…r/aries-framework-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Feat/present proof v2
…r/aries-framework-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Feat/present proof v2
Signed-off-by: NB Prasad Katkar <prasad@northernblock.io>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
Signed-off-by: NB-Karim <karim.northernblock@gmail.com>
|
@NB-MikeRichardson it seems one test is failing, could you take a look at it? |
TimoGlastra
reviewed
Aug 12, 2022
genaris
reviewed
Aug 13, 2022
There was a problem hiding this comment.
I've just added some minor comments regarding RevocationNotificationService that I think belongs to Credential Module.
It would be nice if we can integrate here the changes introduced in #972 but if it's too much trouble we can merge it afterwards.
packages/core/src/modules/proofs/__tests__/ProofsModule.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/proofs/__tests__/ProofsModule.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #979 +/- ##
=============================================
- Coverage 87.64% 87.55% -0.10%
=============================================
Files 574 602 +28
Lines 13539 14549 +1010
Branches 2194 2350 +156
=============================================
+ Hits 11866 12738 +872
- Misses 1669 1806 +137
- Partials 4 5 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
|
I haven't merged in #972 because that PR is not yet in 0.3.0-pre. I am happy to merge that it in in due course: I would say let's get this stuff in first as people are waiting on it. |
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
TimoGlastra
reviewed
Aug 15, 2022
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca>
Signed-off-by: Timo Glastra <timo@animo.id>
Yes I think it would be easier to merge afterwards. I'll merge this PR and we can then update with main (hasn't been done in a while). |
|
Did someone add sonarcloud? |
TimoGlastra
approved these changes
Aug 17, 2022
Signed-off-by: Timo Glastra <timo@animo.id>
|
SonarCloud Quality Gate failed.
|
|
Merging as CI for node 14 passes (still the BBS issue) |
TimoGlastra
pushed a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca> Co-authored-by: NB Prasad Katkar <prasad@northernblock.io> Co-authored-by: Karim Stekelenburg <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca> Co-authored-by: NB Prasad Katkar <prasad@northernblock.io> Co-authored-by: Karim Stekelenburg <karim@animo.id>
TimoGlastra
pushed a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca> Co-authored-by: NB Prasad Katkar <prasad@northernblock.io> Co-authored-by: Karim Stekelenburg <karim@animo.id>
genaris
pushed a commit
to 2060-io/aries-framework-javascript
that referenced
this pull request
Sep 16, 2022
Signed-off-by: Mike Richardson <mike.richardson@ontario.ca> Co-authored-by: NB Prasad Katkar <prasad@northernblock.io> Co-authored-by: Karim Stekelenburg <karim@animo.id> Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a three-way merge of
feat/ppv2
0.3.0-pre
TimoGlastra/refactor/generalize-proofs
BREAKING CHANGE: the present proof module has been extended to support both v1 and v2 of protocol. See Migrating from AFJ 0.2.x to 0.3.0 for a detailed migration instructions.