Update manage to stop on agent failure #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
swcurran
approved these changes
Nov 6, 2024
|
There is an issue with the credo agent I've been working on for a few days now. So this PR stopped the running of tests last night. However the job to push results to Allure ran and it shows empty in the report. Do you think this is ok, or should we skip the results push if tests don't run. It is an indicator that something went wrong and no tests were executed I suppose. I'm leaning to avoiding a results push if tests are skipped. Agreed? |
|
Yes, I think that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a set of tests, and the start routine fails to communicate to one of the designated agents, the execution of the tests would continue. Of course this would cause some or all of the tests to fail. This PR changes that logic and when the test harness does not get a successful startup of an agent, will let the user know there was an issue, skip the running of the tests, and stop any running test harness services. This should end the interop results getting complete failures in the reports when it was just an agent startup issue.