Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: launch ACA-Py securely with API Key #20

Merged

Conversation

anwalker293
Copy link
Contributor

@anwalker293 anwalker293 commented Nov 28, 2023

Due to the nature AWS security groups, opting to have an API key to access the admin UI for ACA-Py.

Otherwise, given an alternative, these portions can be commented out.

Signed-off-by: Alex Walker <alex.walker@indicio.tech>
@anwalker293 anwalker293 marked this pull request as ready for review November 28, 2023 23:31
swcurran
swcurran previously approved these changes Nov 29, 2023
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
@anwalker293
Copy link
Contributor Author

anwalker293 commented Dec 4, 2023

.

@anwalker293 anwalker293 marked this pull request as draft December 4, 2023 21:06
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
@anwalker293 anwalker293 marked this pull request as ready for review December 4, 2023 21:40
@KimEbert42
Copy link
Contributor

What happens if we provide an empty value here? Does it require authentication?

@anwalker293
Copy link
Contributor Author

@reflectivedevelopment It looks like it doesn't even come up (left it as "")

ubuntu-issuer-1  |   File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code
ubuntu-issuer-1  |     exec(code, run_globals)
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/__main__.py", line 74, in <module>
ubuntu-issuer-1  |     main(sys.argv)
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/__main__.py", line 71, in main
ubuntu-issuer-1  |     run(args)
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/__main__.py", line 64, in run
ubuntu-issuer-1  |     run_command(command, args)
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/commands/__init__.py", line 38, in run_command
ubuntu-issuer-1  |     module.execute(argv)
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/commands/start.py", line 49, in execute
ubuntu-issuer-1  |     settings = get_settings(args)
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/config/argparse.py", line 98, in get_settings
ubuntu-issuer-1  |     raise e
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/config/argparse.py", line 95, in get_settings
ubuntu-issuer-1  |     settings.update(group.get_settings(args))
ubuntu-issuer-1  |   File "/home/indy/.venv/lib/python3.9/site-packages/aries_cloudagent/config/argparse.py", line 197, in get_settings
ubuntu-issuer-1  |     raise ArgsParseError(
ubuntu-issuer-1  | aries_cloudagent.config.error.ArgsParseError: Either --admin-api-key or --admin-insecure-mode must be set but not both.

(Had ACAPY_ADMIN_API_KEY="" and

# admin-insecure-mode: true
admin-api-key: ${ACAPY_ADMIN_API_KEY}

)

KimEbert42 and others added 4 commits December 11, 2023 10:25
…urely

Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
@KimEbert42 KimEbert42 merged commit e21608e into openwallet-foundation:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants