-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: launch ACA-Py securely with API Key #20
Merged
KimEbert42
merged 7 commits into
openwallet-foundation:main
from
Indicio-tech:feat/launch-ACAPy-securely
Dec 11, 2023
Merged
feat: launch ACA-Py securely with API Key #20
KimEbert42
merged 7 commits into
openwallet-foundation:main
from
Indicio-tech:feat/launch-ACAPy-securely
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
swcurran
previously approved these changes
Nov 29, 2023
KimEbert42
requested changes
Dec 1, 2023
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
. |
Signed-off-by: Alex Walker <alex.walker@indicio.tech>
What happens if we provide an empty value here? Does it require authentication? |
@reflectivedevelopment It looks like it doesn't even come up (left it as "")
(Had
) |
…urely Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
Signed-off-by: Kim Ebert <kim@indicio.tech>
…curely Feat/launch aca py securely
KimEbert42
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the nature AWS security groups, opting to have an API key to access the admin UI for ACA-Py.
Otherwise, given an alternative, these portions can be commented out.