Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 'input:' optional in call body #524

Closed
wants to merge 2 commits into from
Closed

Conversation

mlin
Copy link
Member

@mlin mlin commented Dec 27, 2022

Just scratching a holiday itch....the input: heading in call bodies is useless clutter AFAICT. Make it optional (for backwards compatibility).

Perhaps the idea was for call bodies to have additional sections (e.g. runtime: for workflow-level overrides). Those could still be added in the future, whilst keeping input: implied if not present.

Checklist

  • Pull request details were added to CHANGELOG.md

@rhpvorderman
Copy link
Contributor

I like this idea. Less is more. I like how it is optional too, having maximal backwards-compatibility where possible is the only way forward. When WDL 2.0 eventually launches I don't want it to become the python 3.0 disaster where only the core devs are on the new stuff and the rest of the world waits for 10+ years.

@patmagee
Copy link
Member

patmagee commented Jan 9, 2023

I love this idea too. I have always felt that in lieu of other properties it was just added boilerplate to the call definition. @mlin are you able to take a stab at updating the grammar bychance?

Copy link
Member

@patmagee patmagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patmagee patmagee added this to the 1.2 milestone Feb 13, 2023
mlin added a commit to chanzuckerberg/miniwdl that referenced this pull request Feb 16, 2023
@jdidion
Copy link
Collaborator

jdidion commented Dec 17, 2023

@mlin please change target to wdl-1.2

@jdidion jdidion closed this May 16, 2024
@jdidion jdidion deleted the mlin/no-call-input-keyword branch May 22, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants