Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use echo instead of cat for number that isn't a file path #660

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

stxue1
Copy link
Collaborator

@stxue1 stxue1 commented Jun 6, 2024

Closes #654

~{number * 2} outputs a number, but cat ~{number *2} tries to read the file named that number, which doesn't work as that file does not exist. This test isn't testing reading from a file but from stdout, so echo should be more appropriate in printing the number to stdout.

I didn't add anything to the changelog as this is more of a bug fix.

Checklist

  • Pull request details were added to CHANGELOG.md
  • Valid examples WDL's were added or updated to the SPEC.md (see the guide on writing markdown tests)

@jdidion jdidion changed the base branch from wdl-1.1 to wdl-1.1.3 June 25, 2024 16:33
Copy link
Collaborator

@jdidion jdidion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebasing to wdl-1.1.3

@jdidion jdidion merged commit 6401dfa into openwdl:wdl-1.1.3 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WDL comment test does not run due to passing in a nonpath string into cat
2 participants